Skip to content

Update security ApiProperty variables#1351

Merged
soyuka merged 2 commits into
api-platform:2.6from
xavren:2.6
Mar 13, 2022
Merged

Update security ApiProperty variables#1351
soyuka merged 2 commits into
api-platform:2.6from
xavren:2.6

Conversation

@xavren

@xavren xavren commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@alanpoulain

Copy link
Copy Markdown
Member

Thanks but I think it's better to favor this one: #1349.

@xavren

xavren commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

Hey @alanpoulain,

request is actually unavailable from variables in this context
object is not the current resource during denormalization but the resourceClass

The PR #1349 actually is adding some informations about previous object that is nice but different from this PR, merging this contributions would be nice

@alanpoulain

Copy link
Copy Markdown
Member

I didn't see the part about the request, sorry.
For the object, it will be null instead of the resource class when api-platform/core#4184 is merged. But it will be on main, so I guess we can merge your PR in the meantime.
I have been too quick, sorry!

@alanpoulain alanpoulain reopened this Apr 27, 2021
@alanpoulain

alanpoulain commented Apr 27, 2021

Copy link
Copy Markdown
Member

Is user available?
Edit: it seems so, in ResourceAccessChecker.
There are also the token and the roles, maybe it would be nice to add them?

@xavren

xavren commented Apr 27, 2021

Copy link
Copy Markdown
Contributor Author

Yes, user is there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants